Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra node timeout setting & json-rpc client connection setting #37

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 1 comment
Open
Tracked by #1
Assignees

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@tkxkd0159
Copy link
Member

tkxkd0159 commented Nov 7, 2023

Ref.

  1. https://github.com/cometbft/cometbft/blob/main/node/node.go#L721-L729
  2. https://github.com/Finschia/ostracon/blob/v1.1.2/node/node.go#L1153-L1166

This issue contains two issues

  1. [json-rpc server] cometbft still set ReadTimeout, WriteTimeout, IdleTimeout with default value [10, 10, 10] and don't support to change this value in config.toml. WriteTimeout changes only depending on TimeoutBroadcastTxCommit in config.toml. It's worth suggesting a change to the upstream, but it's also possible that they don't want it.
  2. [json-rpc client] Ostracon sets MaxIdleConns, MaxIdleConnsPerHost, IdleConnTimeout, ExpectContinueTimeout for json-rpc client [10000, 10000, 60sec, 1sec] whereas cometbft didn't and use default value [no limit, 2, no limit, no limit]
    I don't think it's a necessary change. So if we want to apply this change to upstream, we need to show benchmark test to prove performance improvement.

@tkxkd0159 tkxkd0159 changed the title Triage on ostracon#131 Add extra node timeout setting & json-rpc client connection setting Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants