Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage finschia-sdk#883 #77

Closed
Tracked by #1
0Tech opened this issue Jan 11, 2024 · 2 comments
Closed
Tracked by #1

Triage finschia-sdk#883 #77

0Tech opened this issue Jan 11, 2024 · 2 comments
Assignees

Comments

@0Tech
Copy link

0Tech commented Jan 11, 2024

The subject of the triage:

@170210
Copy link

170210 commented Jan 15, 2024

This PR can be abandoned.
Because cosmos-sdk has already used zerolog in cosmos.io/log.
Related PRs:

But if necessary, we may need to make a PR to finschia/cosmos-sdk with following configuration. (It decided by finschia/cometbft)

	FlagLogPath       = "log_path"
	FlagLogMaxAge     = "log_max_age"
	FlagLogMaxSize    = "log_max_size"
	FlagLogMaxBackups = "log_max_backups"

@170210 170210 self-assigned this Jan 15, 2024
@170210
Copy link

170210 commented Feb 13, 2024

update: Finschia/ostracon#535 has been abandoned by Finschia/cometbft#17, this PR also can be abandoned.

@170210 170210 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants