Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and test MsgStoreCode.instantiate_permission(AccessType) #74

Closed
jaeseung-bae opened this issue Feb 16, 2023 · 1 comment · Fixed by #77
Closed

Implement and test MsgStoreCode.instantiate_permission(AccessType) #74

jaeseung-bae opened this issue Feb 16, 2023 · 1 comment · Fixed by #77
Assignees

Comments

@jaeseung-bae
Copy link
Contributor

jaeseung-bae commented Feb 16, 2023

This unimplemented issue is still TODO status in upstream.
To use AccessType for MsgStoreCode, we need to implement and contribute to upstream as well.

@loin3
Copy link
Contributor

loin3 commented Feb 16, 2023

amino name of each AccessType enum is Nobody, EveryBody, OnlyAddress. They don't work as other enum such as VoteOption in gov module. Because AccessType does not use gogoproto_enum_stringer in proto file, so AccessType implements its own String() method.

I got a clue from dec coin comment

So, instantiate_permission in amino convertor should convert proto msg to amino msg like below.

instantiate_permission: {
  permission: "OnlyAddress",
  address: "link146asaycmtydq45kxc8evntqfgepagygelel00h"
}
or
instantiate_permission: {
  permission: "Nobody",
  address: ""
}
or
instantiate_permission: {
  permission: "Everybody",
  address: ""
}

@loin3 loin3 self-assigned this Feb 20, 2023
@loin3 loin3 closed this as completed in #77 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants