Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare open source #82

Merged
merged 15 commits into from
Apr 20, 2023
Merged

Prepare open source #82

merged 15 commits into from
Apr 20, 2023

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Mar 15, 2023 •
edited
Loading

delete COSMJS_CHANGELOG.md
change contents fo finschia from cosmjs in HACKING.md, README.md
change package name to @finschia/finschia

Description

  • change lbm template to finschia template
  • delete wasm in simapp template which is for finschia-sdk
  • apply finschia to NOTICE, CoC, LICENSE, README, HACKING.md
  • add github template
  • change github workflow for finschia

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 requested a review from zemyblue March 15, 2023 04:59
zemyblue
zemyblue reviewed Mar 15, 2023
View reviewed changes
HACKING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/finschia/package.json Outdated Show resolved Hide resolved
zemyblue
zemyblue reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove CosmJS image In README.md

@loin3 loin3 self-assigned this Mar 20, 2023
@loin3 loin3 requested review from zemyblue March 20, 2023 13:38
zemyblue
zemyblue reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add issue and pr template, and contributing document.

jaeseung-bae
jaeseung-bae approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loin3 loin3 requested review from jaeseung-bae and zemyblue April 19, 2023 09:33
zemyblue
zemyblue reviewed Apr 19, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@loin3 loin3 merged commit f7bcc40 into main Apr 20, 2023
@loin3 loin3 deleted the prepare_open branch April 20, 2023 00:56
@zemyblue zemyblue mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@dudong2 dudong2 dudong2 approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

Assignees

@loin3 loin3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loin3 @zemyblue @dudong2 @jaeseung-bae