Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tests for grpc errors in collection, token modules #87

Merged
merged 8 commits into from
Apr 21, 2023
Merged

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Apr 13, 2023

Description

This pr adds tests for grpc errors in collection, token modules when querying

Motivation and context

Finschia/finschia-sdk@v0.47.0-rc4...v0.47.0-rc5
lbm-sdk change errors when querying to wrap error with grpc specific error

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 force-pushed the test_grpc_errors branch from 6343677 to 438eefa Compare April 13, 2023 12:06
@loin3 loin3 self-assigned this Apr 13, 2023
@loin3 loin3 requested a review from jaeseung-bae April 17, 2023 04:14
@loin3 loin3 requested a review from jaeseung-bae April 19, 2023 04:12
Copy link

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loin3 loin3 merged commit e3ed7f3 into main Apr 21, 2023
@loin3 loin3 deleted the test_grpc_errors branch April 21, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants