Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation for bank balances #362

Closed
4 tasks
egonspace opened this issue Oct 29, 2021 · 0 comments
Closed
4 tasks

Address validation for bank balances #362

egonspace opened this issue Oct 29, 2021 · 0 comments
Assignees
Labels
A: improvement Changes in existing functionality

Comments

@egonspace
Copy link

egonspace commented Oct 29, 2021

Summary

This is the feedback from the QA process of lbm v0.1.0-rc1.

I think we need to check the address when we query balances. At least the bech32 format test should be performed.

$ simd query bank balances link146asaycmtydq45kxc8evntqfgepagygelel00h
balances:
- amount: "89989999900"
  denom: stake
- amount: "100000000000"
  denom: ukrw
pagination:
  next_key: null
  total: "0"
$ simd query bank balances link146asaycmtydq45kxc8evntq
balances:
- amount: "89989999900"
  denom: stake
- amount: "100000000000"
  denom: ukrw
pagination:
  next_key: null
  total: "0"
$ simd query bank balances aaa
balances: []
pagination:
  next_key: null
  total: "0"

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@egonspace egonspace added the A: improvement Changes in existing functionality label Oct 29, 2021
@egonspace egonspace self-assigned this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant