Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to import x/ibc from ibc-go and use it or update it. #585

Closed
shiki-tak opened this issue Jul 8, 2022 · 2 comments · Fixed by #651
Closed

Decide whether to import x/ibc from ibc-go and use it or update it. #585

shiki-tak opened this issue Jul 8, 2022 · 2 comments · Fixed by #651
Assignees

Comments

@shiki-tak
Copy link
Contributor

wasmd v0.27.0 uses v3 of ibc-go.
https://github.com/cosmos/ibc-go/blob/v3.0.0/modules/core/24-host/validate.go#L21

I added DefaultMaxPortCharacterLength becase the source related to ibc has not been update in our repository.

It is necessary to decide whether to import and use or update x/ibc before developing IBCs.

Originally posted by @shiki-tak in #570 (comment)

@shiki-tak shiki-tak mentioned this issue Jul 8, 2022
5 tasks
@zemyblue
Copy link
Member

I think it's better to remove x/ibc module in this repo and import ibc-go.

@ulbqb
Copy link
Member

ulbqb commented Aug 26, 2022

I think it is difficult to import ibc-go. So I updated x/ibc simply.

@ulbqb ulbqb self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants