Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy REST #718

Closed
tkxkd0159 opened this issue Oct 17, 2022 · 0 comments · Fixed by #807
Closed

Remove legacy REST #718

tkxkd0159 opened this issue Oct 17, 2022 · 0 comments · Fixed by #807
Assignees
@tkxkd0159
Labels
A: improvement Changes in existing functionality

Comments

@tkxkd0159
Copy link
Member

tkxkd0159 commented Oct 17, 2022 •
edited
Loading

Overview

Remove all legacy REST-API routes. Use grpc-gw routes instead.

Current Legacy API exposed in swagger

  • /node_info -> /lbm/base/ostracon/v1/node_info
  • /syncing -> /lbm/base/ostracon/v1/syncing
  • /blocks/latest -> /lbm/base/ostracon/v1/blocks/latest
  • /blocks/{height} -> /lbm/base/ostracon/v1/blocks/{height}
  • /validatorsets/latest -> /lbm/base/ostracon/v1/validatorsets/latest
  • /validatorsets/{height} -> /lbm/base/ostracon/v1/validatorsets/{height}

Even though it is not exposed to swagger, all legacy API paths for all modules are currently registered.

Upstream Ref.

cosmos/cosmos-sdk#9594, cosmos/cosmos-sdk#11797
@tkxkd0159 tkxkd0159 self-assigned this Oct 17, 2022
@tkxkd0159 tkxkd0159 added the A: improvement Changes in existing functionality label Oct 17, 2022
@tkxkd0159 tkxkd0159 changed the title refactor: remove legacy REST Remove legacy REST Oct 17, 2022
@tkxkd0159 tkxkd0159 assigned tkxkd0159 and unassigned tkxkd0159 Oct 17, 2022
@tkxkd0159 tkxkd0159 mentioned this issue Nov 25, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkxkd0159 tkxkd0159

Labels
A: improvement Changes in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove legacy REST APIs tkxkd0159/finschia-sdk
1 participant
@tkxkd0159