Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Will Not Be Started If api.server Is Disabled #759

Closed
4 tasks
tkxkd0159 opened this issue Oct 26, 2022 · 0 comments · Fixed by #763
Closed
4 tasks

Telemetry Will Not Be Started If api.server Is Disabled #759

tkxkd0159 opened this issue Oct 26, 2022 · 0 comments · Fixed by #763
Assignees
Labels
A: bug Something isn't working

Comments

@tkxkd0159
Copy link
Member

Summary of Bug

  • server/start.go
  • server/api/server.go

The initialization of telemetry is implemented in function start() in the file server/api/server.go.

  if cfg.Telemetry.Enabled {
      m, err := telemetry.New(cfg.Telemetry)
      if err != nil {
          s.mtx.Unlock()
          return err
      }

      s.metrics = m
      s.registerMetrics()
  }

During the execution of function startInProcess(), if telemetry is enabled in the configuration and the API server is disabled, telemetry will not be started correctly because the function start() in file server/api/server.go will not be invoked.

In addition, the function startStandAlone() also will not start the telemetry correctly if the telemetry is enabled in the configuration.

Failing to start telemetry will make the node miss crucial on-chain metrics and increase the difficulty of future optimization.

Version

e19f863

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tkxkd0159 tkxkd0159 self-assigned this Oct 26, 2022
@tkxkd0159 tkxkd0159 added the A: bug Something isn't working label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant