Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated cosmos proto files. #877

Closed
4 tasks
zemyblue opened this issue Feb 2, 2023 · 1 comment
Closed
4 tasks

Remove duplicated cosmos proto files. #877

zemyblue opened this issue Feb 2, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@zemyblue
Copy link
Member

zemyblue commented Feb 2, 2023

Summary

Remove duplicated cosmos proto files and change custom proto service to lbm proto.

Problem Definition

If other library import lbm-sdk and cosmos-sdk, a duplicate proto type registered warning is occurred like below. It can generate many problems. So we need to remove cosmos-sdk proto file and custom proto struct and service need to change lbm proto.

@mHXCV6H67LX build % ./wasmplusd version
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.crypto.multisig.v1beta1.MultiSignature
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.crypto.multisig.v1beta1.CompactBitArray
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.kv.v1beta1.Pairs
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.kv.v1beta1.Pair
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.snapshots.v1beta1.Snapshot
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.snapshots.v1beta1.Metadata
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.CommitInfo
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.StoreInfo
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.CommitID
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.StoreKVPair
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.TxResponse
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.ABCIMessageLog
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.StringEvent
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.Attribute
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.GasInfo
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.Result
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.SimulationResponse
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.MsgData
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.TxMsgData
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.SearchTxsResult
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.Coin
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.DecCoin
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.IntProto
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.DecProto

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@170210 170210 self-assigned this Jul 11, 2023
@170210 170210 added A: improvement Changes in existing functionality good first issue Good for newcomers and removed A: improvement Changes in existing functionality labels Jul 11, 2023
@170210
Copy link
Contributor

170210 commented Jul 11, 2023

It was resolved by Finschia/wasmd#7

@170210 170210 closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants