fix(crypto): error if incorrect ledger public key #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
- Coverage 70.41% 70.41% -0.01%
==========================================
Files 643 643
Lines 54746 54752 +6
==========================================
+ Hits 38552 38555 +3
- Misses 14020 14022 +2
- Partials 2174 2175 +1
|
jaeseung-bae
requested review from
tkxkd0159,
zemyblue and
0Tech
as code owners
jaeseung-bae
force-pushed
the
fix/missing-check-pubkey
branch
from
ea8728f
to
108e174
Compare
0Tech
approved these changes
Mar 27, 2024
ulbqb
approved these changes
Mar 27, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit e62a330) # Conflicts: # CHANGELOG.md # crypto/keyring/keyring.go
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
…1322) * fix(crypto): error if incorrect ledger public key (#1316) (cherry picked from commit e62a330) # Conflicts: # CHANGELOG.md # crypto/keyring/keyring.go * Apply suggestions from code review --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml