-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc-gw (backport #1153, #1418) #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkxkd0159
changed the title
fix: remove grpc replace directive (backport #1153)
fix: remove grpc replace directive and refactor grpc-web/rosetta (backport #1153, #1418)
Jun 17, 2024
tkxkd0159
changed the title
fix: remove grpc replace directive and refactor grpc-web/rosetta (backport #1153, #1418)
fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc (backport #1153, #1418)
Jun 17, 2024
tkxkd0159
changed the title
fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc (backport #1153, #1418)
fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc-gw (backport #1153, #1418)
Jun 17, 2024
tkxkd0159
added
A: improvement
Changes in existing functionality
C:server
dependencies
Pull requests that update a dependency file
labels
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.49.x #1423 +/- ##
===================================================
+ Coverage 68.08% 68.95% +0.86%
===================================================
Files 770 754 -16
Lines 77606 76124 -1482
===================================================
- Hits 52840 52489 -351
+ Misses 22097 20996 -1101
+ Partials 2669 2639 -30
|
170210
approved these changes
Jun 17, 2024
zemyblue
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: improvement
Changes in existing functionality
C:server
dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
#1153 #1418
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml