Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change automerge conditions of Mergify #523

Merged
merged 2 commits into from
May 9, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 3, 2022

Description

Many dependencies pr is added but it is not check and merged.
So, I think we need to use mergify which merge automatic if the following condition is satisfied.

The condition

  • 2 approve
  • automerge label
  • pass CI

Passing CI must be necessary but the option which all checks have passed is not exist in Mergify options. So the reviewer should to check all checks have passed.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue added the A: CI label May 3, 2022
@zemyblue zemyblue requested review from 0Tech, dudong2 and brew0722 May 3, 2022 11:57
@zemyblue zemyblue merged commit be2ba3e into Finschia:main May 9, 2022
brew0722 pushed a commit to brew0722/lbm-sdk that referenced this pull request May 11, 2022
* main:
  fix: genesis auth account format (Finschia#517)
  Remove reviewers on dependabot.yml
  updated ostracon to v1.0.5; `unsafe-reset-all` command has been moved to the `ostracon` sub-command. (Finschia#536)
  build(deps): bump docker/build-push-action from 2 to 3 (Finschia#532)
  build(deps): bump docker/metadata-action from 3 to 4 (Finschia#530)
  build(deps): bump docker/login-action from 1 to 2 (Finschia#531)
  build(deps): bump docker/setup-buildx-action from 1 to 2 (Finschia#529)
  chore(deps): bump github.com/VictoriaMetrics/fastcache from 1.9.0 to 1.10.0 (Finschia#499)
  build(deps): bump google.golang.org/protobuf from 1.27.1 to 1.28.0 (Finschia#474)
  chore(deps): bump github.com/prometheus/common from 0.32.1 to 0.34.0 (Finschia#510)
  chore(deps): bump github.com/coinbase/rosetta-sdk-go from 0.7.0 to 0.7.9 (Finschia#520)
  build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (Finschia#458)
  build(deps): bump github.com/confio/ics23/go from 0.6.6 to 0.7.0 (Finschia#448)
  build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (Finschia#465)
  build(deps): bump github.com/armon/go-metrics from 0.3.10 to 0.3.11 (Finschia#522)
  build(deps): bump github.com/magiconair/properties from 1.8.5 to 1.8.6 (Finschia#445)
  ci: change automerge conditions of Mergify (Finschia#523)
@zemyblue zemyblue deleted the feat/mergify branch May 19, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants