Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add index field into TxResponse #526

Merged
merged 7 commits into from
May 16, 2022

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented May 4, 2022

Description

closes: #507

ostracon's Tx() API returns an index, but QueryTx() of the lbm-sdk that wraps it does not return an index.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@brew0722 brew0722 added the A: improvement Changes in existing functionality label May 4, 2022
@brew0722 brew0722 requested review from 0Tech, dudong2 and zemyblue May 4, 2022 05:04
@brew0722 brew0722 marked this pull request as ready for review May 4, 2022 05:05
@brew0722 brew0722 self-assigned this May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #526 (9b26052) into main (19355d6) will increase coverage by 0.49%.
The diff coverage is 76.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   56.84%   57.34%   +0.49%     
==========================================
  Files         777      791      +14     
  Lines       83633    86263    +2630     
==========================================
+ Hits        47543    49469    +1926     
- Misses      33010    33644     +634     
- Partials     3080     3150      +70     
Impacted Files Coverage Δ
types/abci.pb.go 0.47% <0.00%> (-0.01%) ⬇️
x/foundation/codec.go 0.00% <0.00%> (ø)
x/foundation/config.go 0.00% <0.00%> (ø)
x/foundation/events.go 0.00% <0.00%> (ø)
x/foundation/keeper/abci.go 0.00% <0.00%> (ø)
x/foundation/keeper/migrations.go 0.00% <ø> (ø)
x/foundation/proposal.go 5.35% <7.69%> (ø)
x/foundation/keeper/treasury.go 17.39% <17.39%> (ø)
x/foundation/keeper/grpc_query.go 18.35% <18.35%> (ø)
x/foundation/foundation.go 38.39% <38.39%> (ø)
... and 22 more

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jiyong Ha added 3 commits May 11, 2022 15:50
* main:
  fix: genesis auth account format (Finschia#517)
  Remove reviewers on dependabot.yml
  updated ostracon to v1.0.5; `unsafe-reset-all` command has been moved to the `ostracon` sub-command. (Finschia#536)
  build(deps): bump docker/build-push-action from 2 to 3 (Finschia#532)
  build(deps): bump docker/metadata-action from 3 to 4 (Finschia#530)
  build(deps): bump docker/login-action from 1 to 2 (Finschia#531)
  build(deps): bump docker/setup-buildx-action from 1 to 2 (Finschia#529)
  chore(deps): bump github.com/VictoriaMetrics/fastcache from 1.9.0 to 1.10.0 (Finschia#499)
  build(deps): bump google.golang.org/protobuf from 1.27.1 to 1.28.0 (Finschia#474)
  chore(deps): bump github.com/prometheus/common from 0.32.1 to 0.34.0 (Finschia#510)
  chore(deps): bump github.com/coinbase/rosetta-sdk-go from 0.7.0 to 0.7.9 (Finschia#520)
  build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (Finschia#458)
  build(deps): bump github.com/confio/ics23/go from 0.6.6 to 0.7.0 (Finschia#448)
  build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (Finschia#465)
  build(deps): bump github.com/armon/go-metrics from 0.3.10 to 0.3.11 (Finschia#522)
  build(deps): bump github.com/magiconair/properties from 1.8.5 to 1.8.6 (Finschia#445)
  ci: change automerge conditions of Mergify (Finschia#523)
* main:
  feat: add foundation treasury feature to x/foundation (Finschia#518)
  chore(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (Finschia#540)
  build(deps): bump github.com/hashicorp/go-getter from 1.4.1 to 1.5.11 in /cosmovisor (Finschia#525)

# Conflicts:
#	client/docs/statik/statik.go
@brew0722 brew0722 merged commit 1f94632 into Finschia:main May 16, 2022
@brew0722 brew0722 deleted the add_index_field branch May 16, 2022 05:24
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need the tx_index via TxResponse
3 participants