-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove x/wasm
module
#850
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 63.12% 62.78% -0.34%
==========================================
Files 868 812 -56
Lines 100292 92179 -8113
==========================================
- Hits 63307 57873 -5434
+ Misses 33457 31055 -2402
+ Partials 3528 3251 -277
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot add unittest below two parts to indicate no coverage. Because this is IBC integrate test code and it is tested other integration test. So please ignore the codecov/patch
error of ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* main: refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
* main: (30 commits) chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860) chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854) feat: Remove `x/wasm` module (Finschia#850) refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853) feat: enable querying based on mempool status (only gRPC) (Finschia#840) feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848) chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845) chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847) chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841) fix: apply foundation audit (Finschia#834) chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831) chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839) ci: automate release process (Finschia#829) chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832) chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830) chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826) chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822) chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828) feat: Get validator pubkey considering KMS (Finschia#821) Remove support for composite (BLS) key type (Finschia#817) ... # Conflicts: # x/foundation/msgs.go # x/wasm/lbmtypes/codec.go # x/wasm/types/codec.go
Description
Detach
x/wasm
module to other repository. line/wasmdMotivation and context
We have had a difficult to bump up the upstream cosmwasm/wasmd in lbm-sdk. Because the commit history is difference and the references git is difference, we cannot use merely git merge. So we need to detach
x/wasm
module likecosmwasm/wasmd
.How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml