Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set upgrade handler for v2-Daisy #250

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

0Tech
Copy link
Contributor

@0Tech 0Tech commented Aug 7, 2023

Description

This patch adds upgrade handler for v2-Daisy in-place migration.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@0Tech 0Tech self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (rc/v2.0.0-rcx@ef1cf05). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             rc/v2.0.0-rcx     #250   +/-   ##
================================================
  Coverage                 ?   49.23%           
================================================
  Files                    ?        9           
  Lines                    ?     1373           
  Branches                 ?        0           
================================================
  Hits                     ?      676           
  Misses                   ?      652           
  Partials                 ?       45           

@0Tech 0Tech marked this pull request as ready for review August 7, 2023 03:35
jaeseung-bae
jaeseung-bae previously approved these changes Aug 7, 2023
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zemyblue
zemyblue previously approved these changes Aug 7, 2023
app/app.go Show resolved Hide resolved
@zemyblue zemyblue added this to the v2.0.0 milestone Aug 8, 2023
@0Tech 0Tech merged commit 7d611f5 into Finschia:rc/v2.0.0-rcx Aug 8, 2023
@0Tech 0Tech deleted the upgrade-handler branch August 8, 2023 06:59
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants