Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use curl instead of wget on MacOS #284

Merged
merged 2 commits into from
Oct 19, 2023
Merged

build: use curl instead of wget on MacOS #284

merged 2 commits into from
Oct 19, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 17, 2023 •
edited
Loading

Description

closes: #XXXX

wget is not a default tool on MacOS

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@tkxkd0159 tkxkd0159 self-assigned this Oct 17, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tkxkd0159 tkxkd0159 changed the title fix: use curl instead of wget on MacOS build: use curl instead of wget on MacOS Oct 17, 2023
@tkxkd0159 tkxkd0159 merged commit 597ace4 into rc/v2.0.0-rcx Oct 19, 2023
33 checks passed
@tkxkd0159 tkxkd0159 deleted the fix-wget-err branch October 19, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@zemyblue zemyblue zemyblue approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech

Assignees

@tkxkd0159 tkxkd0159

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkxkd0159 @CLAassistant @zemyblue @jaeseung-bae