Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused modules from app #87

Merged
merged 3 commits into from
Aug 23, 2022
Merged

fix: remove unused modules from app #87

merged 3 commits into from
Aug 23, 2022

Conversation

0Tech
Copy link
Contributor

@0Tech 0Tech commented Aug 22, 2022

Description

This patch removes the following modules:

  • x/collection
  • x/token
  • x/ibc
  • x/transfer

Closes: #85

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@0Tech 0Tech self-assigned this Aug 22, 2022
@0Tech 0Tech marked this pull request as ready for review August 22, 2022 03:52
shiki-tak
shiki-tak approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit b720cb7 into main Aug 23, 2022
@0Tech 0Tech deleted the remove_modules branch August 23, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@tnasu tnasu tnasu approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue zemyblue is a code owner

@dudong2 dudong2 Awaiting requested review from dudong2

@loloicci loloicci Awaiting requested review from loloicci

Assignees

@0Tech 0Tech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure lbm binary of Finschia
3 participants
@0Tech @tnasu @shiki-tak