Remove the voter election process #543

ulbqb · 2023-01-17T04:02:15Z

Abstract

This PR remove the voter election process from Ostracon.

Background

Ostracon need some compatibility with Tendermint for IBC and cosmos-sdk. It it necessary to change possible parts for compatibility. Currently the voter election process is executed in Ostracon. Since voter selection can be moved to the lbm-sdk layer, it want to be moved to the lbm-sdk layer without putting it in Ostracon.

Goal

The goal is to fix to be compatible with Tendermint about voter election process. This means that the voter election process is removed from ostracon and it is done by only abci app. This goal need the following changes.

Remove the voter election process
Remove the proto field related to voter election
- Removevoter_params, voter, voters, last_voters, voters_hash, voter_set, voting_weight that does not exist in Tendermint.
- voter_params is the parameters used by voter election so this is not needed.
- voters is the nodes elected from validators so this is not needed.
- voting_weight is the value recalculated as voting power in voters so this is not needed.
Remove RPCs related to voter
- Voters, ValidatorsWithVoters
FIx openapi.yaml
Fix documents

Policy

The changes is based on Tendermint v0.34.19.
This PR contains fixes other than documentation fixes. Fixing the documents is in #544.

Results

The voter election process was removed from ostracon. However, voter selection can still be implemented with the abci app. This PR makes it impossible to change the validator for each round. Updating validators is perform in EndBlock. See tendermint docs for details.

codecov · 2023-01-17T04:09:11Z

Codecov Report

Merging #543 (6d004af) into main (6010b48) will decrease coverage by 0.08%.
The diff coverage is 74.80%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   66.15%   66.08%   -0.08%     
==========================================
  Files         279      278       -1     
  Lines       37593    36981     -612     
==========================================
- Hits        24871    24440     -431     
+ Misses      10947    10787     -160     
+ Partials     1775     1754      -21

Impacted Files	Coverage Δ
blockchain/v2/processor_context.go	`67.44% <0.00%> (ø)`
cmd/ostracon/commands/init.go	`84.21% <ø> (-0.28%)`	⬇️
config/toml.go	`74.19% <ø> (ø)`
consensus/replay_file.go	`0.00% <0.00%> (ø)`
consensus/types/round_state.go	`0.00% <0.00%> (ø)`
light/errors.go	`75.00% <ø> (ø)`
rpc/client/mock/client.go	`19.29% <ø> (+0.65%)`	⬆️
rpc/core/consensus.go	`32.35% <ø> (-27.03%)`	⬇️
rpc/core/routes.go	`0.00% <ø> (ø)`
rpc/core/types/responses.go	`35.71% <ø> (ø)`
... and 48 more

This reverts commit 3cab0a5.

consensus/reactor_test.go

test/e2e/tests/validator_test.go

torao · 2023-01-18T07:29:50Z

I can then accept this PR if the details of the backgrounds and objectives of this modification are written.

statesync/stateprovider_test.go

proto/ostracon/types/evidence.proto

proto/ostracon/abci/types.proto

proto/ostracon/types/evidence.proto

ulbqb · 2023-01-19T03:05:48Z

@torao
I updated PR description. Please comment if anything is missing.

torao · 2023-01-19T11:22:05Z

@ulbqb
Does LINE Blockchain no longer support Voter elections? If so, how about the reward payout would? Or if not, how to implement voter election? This should be important information for product design.

zemyblue · 2023-01-20T01:43:21Z

@ulbqb
Does LINE Blockchain no longer support Voter elections? If so, how about the reward payout would? Or if not, how to implement voter election? This should be important information for product design.

@torao , we need to move this voter selection function to lbm-sdk layer later.

zemyblue

Currently the voter election process is executed in Ostracon. However, if Ostracon's spec follows Tendermint's spec for this process, Ostracon should not have vote election process. Because Tendermint is not responsible for voter election, it is done by abci app.

@ulbqb , I think it is not a problem of description.
Ostracon need some compatibility with Tendermint for IBC and cosmos-sdk. So I think this PR is necessary because it is necessary to change possible parts for compatibility, and since voter selection can be moved to the lbm-sdk layer, it is moved to the lbm-sdk layer without putting it in Ostracon.

ulbqb · 2023-01-20T02:14:50Z

@ulbqb
Does LINE Blockchain no longer support Voter elections? If so, how about the reward payout would? Or if not, how to implement voter election? This should be important information for product design.

@torao Voter selection and reward logic can be freely implemented with abci app(lbm-sdk). Updating validators is perform in EndBlock. See tendermint docs for details.

abci/client/mocks/client.go

Kynea0b

LGTM (Just in case, this PR will be merged after someone else's review.)

torao · 2023-01-20T10:22:46Z

@zemyblue @ulbqb All right. We have an implicit agreement in our private discussion about how to conduct voter elections, but this PR only contains bits and pieces of information, which is why I asked the question.

To state our conclusion for those interested in LINE Blockchain, we plan to move the behaviour known as voter election from ostracon to the lbm-sdk. This is because in Tendermint, the selection of Validators is the responsibility of the Cosmos-SDK and we have chosen to follow that approach. In this PR, we'll remove the voter election from Ostracon and implement it in a future update to the lbm-sdk.

egonspace · 2023-02-09T04:59:00Z

Hi guys~
Wow, this is amazing!
If so, do you give up functions such as selecting proposer according to probability? I don't think the sdk layer can be involved in selecting the proposer.

ulbqb · 2023-02-09T08:02:19Z

@egonspace
Hello.

If so, do you give up functions such as selecting proposer according to probability?

No. This PR removed only the voter election from ostracon. The proposer election is still run by ostracon.

Kynea0b assigned ulbqb Jan 17, 2023

ulbqb force-pushed the fix/remove_voter_election branch 2 times, most recently from ed62360 to 2f3828a Compare January 17, 2023 05:51

ulbqb added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jan 17, 2023

ulbqb changed the title ~~Remove voter election process~~ Remove the voter election process Jan 17, 2023

ulbqb force-pushed the fix/remove_voter_election branch 2 times, most recently from 8eb65e3 to 66de98b Compare January 17, 2023 07:28

ulbqb added 6 commits January 17, 2023 17:01

Fix proto

2e35c6e

Fix prod code

f795a09

Fix mocks

17e693a

Fix openapi

bdbff92

Fix docs

3cab0a5

Fix tests

1fce309

ulbqb force-pushed the fix/remove_voter_election branch from 66de98b to 1fce309 Compare January 17, 2023 08:01

ulbqb marked this pull request as ready for review January 17, 2023 08:29

ulbqb requested review from Kynea0b, torao and tnasu as code owners January 17, 2023 08:29

Revert "Fix docs"

6c9aa07

This reverts commit 3cab0a5.

torao reviewed Jan 18, 2023

View reviewed changes

consensus/reactor_test.go Show resolved Hide resolved

test/e2e/tests/validator_test.go Show resolved Hide resolved

tnasu requested changes Jan 18, 2023

View reviewed changes

statesync/stateprovider_test.go Outdated Show resolved Hide resolved

proto/ostracon/types/evidence.proto Outdated Show resolved Hide resolved

proto/ostracon/abci/types.proto Outdated Show resolved Hide resolved

tnasu reviewed Jan 18, 2023

View reviewed changes

proto/ostracon/types/evidence.proto Outdated Show resolved Hide resolved

Fix for reviews

6d004af

ulbqb requested a review from tnasu January 19, 2023 02:45

ulbqb requested a review from torao January 19, 2023 04:14

tnasu approved these changes Jan 19, 2023

View reviewed changes

zemyblue reviewed Jan 20, 2023

View reviewed changes

Kynea0b reviewed Jan 20, 2023

View reviewed changes

abci/client/mocks/client.go Show resolved Hide resolved

Kynea0b approved these changes Jan 20, 2023

View reviewed changes

Kynea0b self-requested a review January 20, 2023 09:12

torao approved these changes Jan 20, 2023

View reviewed changes

ulbqb merged commit b3b255c into Finschia:main Jan 22, 2023

ulbqb deleted the fix/remove_voter_election branch January 22, 2023 11:22

zemyblue mentioned this pull request Jan 25, 2023

feat!: replace a some same proto message to Tendermint #546

Merged

This was referenced Feb 1, 2023

Remove VRF Proof from header for compatibility #554

Closed

Move VRF proof from Header to Entropy for compatibity #559

Merged

zemyblue mentioned this pull request Feb 9, 2023

Add voter election with VRF Finschia/finschia-sdk#888

Open

torao mentioned this pull request Feb 9, 2023

Remove the ability to select more than one for random sampling #563

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the voter election process #543

Remove the voter election process #543

ulbqb commented Jan 17, 2023 •

edited

Loading

codecov bot commented Jan 17, 2023 •

edited

Loading

torao commented Jan 18, 2023

ulbqb commented Jan 19, 2023

torao commented Jan 19, 2023

zemyblue commented Jan 20, 2023

zemyblue left a comment •

edited

Loading

ulbqb commented Jan 20, 2023 •

edited

Loading

Kynea0b left a comment •

edited

Loading

torao commented Jan 20, 2023 •

edited

Loading

egonspace commented Feb 9, 2023

ulbqb commented Feb 9, 2023

Remove the voter election process #543

Remove the voter election process #543

Conversation

ulbqb commented Jan 17, 2023 • edited Loading

Abstract

Background

Goal

Policy

Results

codecov bot commented Jan 17, 2023 • edited Loading

Codecov Report

torao commented Jan 18, 2023

ulbqb commented Jan 19, 2023

torao commented Jan 19, 2023

zemyblue commented Jan 20, 2023

zemyblue left a comment • edited Loading

Choose a reason for hiding this comment

ulbqb commented Jan 20, 2023 • edited Loading

Kynea0b left a comment • edited Loading

Choose a reason for hiding this comment

torao commented Jan 20, 2023 • edited Loading

egonspace commented Feb 9, 2023

ulbqb commented Feb 9, 2023

ulbqb commented Jan 17, 2023 •

edited

Loading

codecov bot commented Jan 17, 2023 •

edited

Loading

zemyblue left a comment •

edited

Loading

ulbqb commented Jan 20, 2023 •

edited

Loading

Kynea0b left a comment •

edited

Loading

torao commented Jan 20, 2023 •

edited

Loading