-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entropy correctness test #565
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 66.07% 66.08% +0.01%
==========================================
Files 278 277 -1
Lines 36999 36946 -53
==========================================
- Hits 24446 24416 -30
+ Misses 10791 10773 -18
+ Partials 1762 1757 -5
|
Just the wording, but "uniqueness" asserts that "never duplicates" (i.e. can be used for such as primary keys or node ids); verification and correctness seem better in terms of Entropy's behaviour and this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@torao |
Description
PR #559 adds Entropy to Block and says that Entropy is single at every height. But that was not tested. So this PR adds a test that checks Entropy is single in every height. The following items need to be confirmed:
https://github.com/line/ostracon/blob/7ca9a208a1729226638c503e019513ae3c8b76dd/types/block.go#L171-L190
https://github.com/line/ostracon/blob/7ca9a208a1729226638c503e019513ae3c8b76dd/types/part_set.go#L167-L195
Closes: #XXX