From 301d330069e6e378a104856677d032eade860994 Mon Sep 17 00:00:00 2001 From: Shogo Hyodo Date: Mon, 11 Mar 2024 15:47:22 +0900 Subject: [PATCH 1/2] Remove unnecessary condition --- privval/signer_listener_endpoint.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/privval/signer_listener_endpoint.go b/privval/signer_listener_endpoint.go index 44b3a3c37..5a7d8e8b3 100644 --- a/privval/signer_listener_endpoint.go +++ b/privval/signer_listener_endpoint.go @@ -2,10 +2,11 @@ package privval import ( "fmt" - "github.com/Finschia/ostracon/privval/internal" "net" "time" + "github.com/Finschia/ostracon/privval/internal" + privvalproto "github.com/tendermint/tendermint/proto/tendermint/privval" "github.com/Finschia/ostracon/libs/log" @@ -29,7 +30,7 @@ func SignerListenerEndpointTimeoutReadWrite(timeout time.Duration) SignerListene // connections from the only allowed addresses func SignerListenerEndpointAllowAddress(protocol string, allowedAddresses []string) SignerListenerEndpointOption { return func(sl *SignerListenerEndpoint) { - if protocol == "tcp" || len(protocol) == 0 { + if protocol == "tcp" { sl.connFilter = internal.NewIpFilter(allowedAddresses, sl.Logger) return } From 5144c7b76075fa989dc729866cf05a9a6f2522da Mon Sep 17 00:00:00 2001 From: Shogo Hyodo Date: Wed, 13 Mar 2024 17:40:02 +0900 Subject: [PATCH 2/2] Update privval/signer_listener_endpoint.go Co-authored-by: murogari <55307968+Mdaiki0730@users.noreply.github.com> --- privval/signer_listener_endpoint.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/privval/signer_listener_endpoint.go b/privval/signer_listener_endpoint.go index 5a7d8e8b3..cfd272f07 100644 --- a/privval/signer_listener_endpoint.go +++ b/privval/signer_listener_endpoint.go @@ -5,11 +5,10 @@ import ( "net" "time" - "github.com/Finschia/ostracon/privval/internal" - privvalproto "github.com/tendermint/tendermint/proto/tendermint/privval" "github.com/Finschia/ostracon/libs/log" + "github.com/Finschia/ostracon/privval/internal" "github.com/Finschia/ostracon/libs/service" tmsync "github.com/Finschia/ostracon/libs/sync" ocprivvalproto "github.com/Finschia/ostracon/proto/ostracon/privval"