Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong wasmplus amino codec register #12

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

loin3
Copy link

@loin3 loin3 commented Feb 22, 2023

Description

closes: #11

  1. When registering wasmplus amino codec, wrong message type name registered. currently "wasm/StoreCodeAndInstantiateContract", this should be "wasm/MsgStoreCodeAndInstantiateContract" like other messages.
  2. When MsgStoreCodeAndInstantiateContract:: GetSignBytes is called wrong codec was called. currently wasm's codec is called which MsgStoreCodeAndInstantiateContract is not registered. wasmplus codec should be used.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #12 (7aceec2) into main (9104d00) will increase coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 7aceec2 differs from pull request most recent head 28fd226. Consider uploading reports for the commit 28fd226 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   60.81%   60.83%   +0.02%     
==========================================
  Files          80       80              
  Lines        9879     9879              
==========================================
+ Hits         6008     6010       +2     
+ Misses       3555     3553       -2     
  Partials      316      316              
Impacted Files Coverage Δ
x/wasmplus/types/tx.go 67.64% <50.00%> (+5.88%) ⬆️
x/wasmplus/types/codec.go 51.85% <100.00%> (ø)

@loin3 loin3 requested a review from zemyblue February 23, 2023 13:35
@loin3 loin3 merged commit 962f37d into Finschia:main Mar 14, 2023
@loin3 loin3 deleted the fix/wrong_wasmplus_codec branch March 14, 2023 06:50
@zemyblue zemyblue mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsgStoreCodeAndInstantiateContract amino signature verify fail
3 participants