feat: separate custom features in x/wasm into x/wasmplus module
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 58.88% 60.80% +1.92%
==========================================
Files 63 80 +17
Lines 9002 9877 +875
==========================================
+ Hits 5301 6006 +705
- Misses 3396 3555 +159
- Partials 305 316 +11
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+826
to
+828
| for acc := range maccPerms { | ||
| modAccAddrs[authtypes.NewModuleAddress(acc).String()] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+837
to
+839
| for acc := range maccPerms { | ||
| blockedAddrs[authtypes.NewModuleAddress(acc).String()] = !allowedReceivingModAcc()[acc] | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+919
to
+921
| for k, v := range maccPerms { | ||
| dupMaccPerms[k] = v | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+227
to
+229
| for _, v := range keys { | ||
| ms.MountStoreWithDB(v, sdk.StoreTypeIAVL, db) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+231
to
+233
| for _, v := range tkeys { | ||
| ms.MountStoreWithDB(v, sdk.StoreTypeTransient, db) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+236
to
+238
| for _, v := range memKeys { | ||
| ms.MountStoreWithDB(v, sdk.StoreTypeMemory, db) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+296
to
+298
| for acc := range maccPerms { | ||
| blockedAddrs[authtypes.NewModuleAddress(acc).String()] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
zemyblue
force-pushed
the
feat/separate_wasmplus2
branch
from
3195a93 to
1eb8763
Compare
zemyblue
changed the title
x/wasmd into x/wasmplus modulex/wasm into x/wasmplus module
|
When I run the command with the built binary, I get the following message, is this OK? |
This duplicate registery is a problem. But this problem need to fix in lbm-sdk. I added this issue as Finschia/finschia-sdk#877. |
|
I have some questions
|
I want to keep the codes of original cosmwasm/wasmd without changes. But your opinion is also good. I'll remove wasmplusd and replace wasmd for
Oh, I'll check it. Good. |
|
Is it possible to change the Usage of wasmplusd from wasmd to wasmplusd while still coexisting with the wasmd app? |
shiki-tak
reviewed
Feb 3, 2023
When I check again, some unittest of
|
shiki-tak
reviewed
Feb 3, 2023
|
When you update the proto file, please also update the proto-gen. |
loloicci
reviewed
Feb 3, 2023
- move all function of `wasmplus/keeper/keeper_extension.go` to `wasmplus/keeper/keeper.go` - remove no need files (keeper_extension.go, metrics.go)
loloicci
approved these changes
Feb 6, 2023
tkxkd0159
approved these changes
Feb 6, 2023
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6
x/wasmdintox/wasmplusmodule.x/wasmplusmodule wraps tx, query apis and everything ofx/wasmmodule.apppluscli forx/wasmplusto avoid import cycle problem.Why remove custom genesis params
The
gas_multiplier,instance_costandcompile_costof added custom genesis param are added to be enable to modify by proposal. And these params decide the gas fee when store and instantiate a smart contract.However, we are using default values not change and we cannot control it without modifying the original source code.
So I think it's better to keep original logic, and change these const value and migrate if we need to modify this gas cost.
Why remove custom query and tx msg encoding feature
Motivation and context
x/wasmdmodules is origin wasmd module, but we did modify it. So we need to fix many conflicts when bump up original changes. So I think it's good to keep originalx/wasmdmodule and separate the custom featues intox/wasmplus.How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml