Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to add a custom domain to long live channelid other than live? #288

Open
yangcheng opened this issue May 24, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@yangcheng
Copy link

The use case you're trying to solve

as it's mentioned in the doc. ChannelID has one use case,

You usually want to leave this blank so that each PR gets its own preview channel. An exception might be that you always want to deploy a certain branch to a long-lived preview channel (for example, you may want to deploy every commit from your next branch to a preprod preview channel).

I want to have a preprod.example.com pointing to the particular preview URL. which current contains a random hash.

Change to the action that would solve that use case

I can set a custom domain either in firebase console, or via yaml file if I have *.example.com verifed.

Other considerations

@yangcheng yangcheng added the enhancement New feature or request label May 24, 2023
@Adyaapatil09
Copy link

Yes that would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants