Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GitHub comment not appearing #294

Open
kasvith opened this issue Jun 29, 2023 · 2 comments
Open

[BUG] GitHub comment not appearing #294

kasvith opened this issue Jun 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@kasvith
Copy link

kasvith commented Jun 29, 2023

Action config

      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
          channelId: preview
          projectId: appname

Error message

No Errors

Expected behavior

GithHub comment to be appear in PR

Actual behavior

No comments appearing in PR. But we get the deploy URL in the deploy log

@kasvith kasvith added the bug Something isn't working label Jun 29, 2023
@seth-acuitymd
Copy link

I think I'm running into the same issue - are you seeing

Deploying to Firebase Preview Channel <channel name> 
Commenting on PR

in your build logs, or just the Deploying... line?

Can I ask what your trigger is for your GitHub Action? (push to branch, PR created, etc etc)

@mpuxted
Copy link

mpuxted commented Feb 12, 2024

I thought I had the same issue, but then I realised that it will only comment once, meaning even if you deploy again it won't add a new comment. This could be made clearer in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants