Merge pull request #268 from howking/master

Fixes for firebase-storage typo comments, refer to __putString method and supress log message
FirebaseExtended · Sep 27, 2017 · b8700b5 · b8700b5
2 parents 645371a + c5ba4ec
commit b8700b5
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 8 deletions.
diff --git a/firebase-storage-behavior.html b/firebase-storage-behavior.html
@@ -50,6 +50,14 @@
         forceUnique: {
           type: Boolean,
           value: false
+        },
+
+        /**
+         * When true, will perform detailed logging.
+         */
+        log: {
+          type: Boolean,
+          value: false
         }
       },
 
@@ -88,7 +96,17 @@
         return storage.ref(path);
       },
 
-      __pathChanged: function(path) {}
+      __pathChanged: function(path) {},
+
+      /**
+       * A wrapper around `console.log`.
+       */
+      _log: function() {
+        if (this.log) {
+          console.log.apply(console, arguments);
+        }
+      }
+
     };
 
     /** @polymerBehavior */

diff --git a/firebase-storage-multiupload.html b/firebase-storage-multiupload.html
@@ -52,14 +52,14 @@
     *
     *   file-task
     *
-    *     <file-storage-upload-task
+    *     <firebase-storage-upload-task
     *       task="[[item]]""
     *       bytes-transferred="{{bytesTransferred}}"
     *       total-bytes="{{totalBytes}}"
     *       state="{{state}}"
     *       download-url="{{downloadUrl}}"
     *       metadata="{{metadata}}"
-    *       path="{{path}}"></file-storage-upload-task>
+    *       path="{{path}}"></firebase-storage-upload-task>
     *
     * ```
     *
@@ -73,14 +73,14 @@
     *     </firebase-storage-multiupload>
     *
     *     <template is="dom-repeat" items="[[uploadTasks]]">
-    *       <file-storage-upload-task
+    *       <firebase-storage-upload-task
     *         task="[[item]]""
     *         bytes-transferred="{{item.bytesTransferred}}"
     *         total-bytes="{{item.totalBytes}}"
     *         state="{{item.state}}"
     *         download-url="{{item.downloadUrl}}"
     *         metadata="{{item.metadata}}"
-    *         path="{{item.path}}"></file-storage-upload-task>
+    *         path="{{item.path}}"></firebase-storage-upload-task>
     *     </template>
     * ```
     *

diff --git a/firebase-storage-ref.html b/firebase-storage-ref.html
@@ -160,7 +160,7 @@
       *  Stores a string in a given format
       */
       putString: function(data, format, metadata) {
-        this.uploadTask = this.__put(null, data, format, metadata);
+        this.uploadTask = this.__putString(null, data, format, metadata);
         return this.uploadTask;
       },
 

diff --git a/firebase-storage-upload-task.html b/firebase-storage-upload-task.html
@@ -18,14 +18,14 @@
     *
     * For example:
     *
-    *     <file-storage-upload-task
+    *     <firebase-storage-upload-task
     *       task="[[task]]"
     *       bytes-transferred="{{bytesTransferred}}"
     *       total-bytes="{{totalBytes}}"
     *       state="{{state}}"
     *       download-url="{{downloadUrl}}"
     *       metadata="{{metadata}}"
-    *       path="{{path}}"></file-storage-upload-task>
+    *       path="{{path}}"></firebase-storage-upload-task>
     *
     * It has to get the upload task from either the firebase-storage-multiupload or firebase-storage-ref
     * and produces data like bytes-transferred, total-bytes, states, etc...