From 16dd97de1a9709d98d7db5c61fec7e3eb6c65a1f Mon Sep 17 00:00:00 2001
From: Laurenz Rasche <laurenz@fixmycity.de>
Date: Mon, 7 Oct 2024 10:35:25 +0200
Subject: [PATCH] add TODO: `unexpected_bicycle_access_on_footway`

---
 .../roads_bikelanes/bikelanes/BikelaneTodos.lua    | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/processing/topics/roads_bikelanes/bikelanes/BikelaneTodos.lua b/processing/topics/roads_bikelanes/bikelanes/BikelaneTodos.lua
index 2d01c9f6..1a1957b8 100644
--- a/processing/topics/roads_bikelanes/bikelanes/BikelaneTodos.lua
+++ b/processing/topics/roads_bikelanes/bikelanes/BikelaneTodos.lua
@@ -150,6 +150,17 @@ local deprecated_cycleway_shared = BikelaneTodo.new({
   end
 })
 
+local unexpected_bicycle_access_on_footway = BikelaneTodo.new({
+  id = "unexpected_bicycle_access_on_footway",
+  desc = "Expected `highway=path+bicycle=designated` (informal/explicit DE:240)" ..
+    "or `highway=footway+bicycle=yes` (informal/explicit DE:239,1022-10);"..
+    " Add traffic_sign=none to specify unsigned path.",
+  conditions = function(objectTags, resultTags)
+    if objectTags.highway == 'footway' and objectTags.bicycle == 'designated' and resultTags.category == 'needsClarification' then
+      return true
+    end
+  end
+})
 
 BikelaneTodos = {
   missing_traffic_sign,
@@ -163,5 +174,6 @@ BikelaneTodos = {
   missing_segregated,
   missing_sidepath,
   missing_cycleway_lane,
-  deprecated_cycleway_shared
+  deprecated_cycleway_shared,
+  unexpected_bicycle_access_on_footway
 }