Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when Manual Scraping From Links With Repeating Chapter Names #27

Closed
brandontruongg opened this issue May 14, 2020 · 1 comment
Closed

Comments

@brandontruongg
Copy link

When you manually scrape from a table of contents link and there is repeats in the link text (e.g. there is multiple "Chapter 1"s) the html file of these will all be named "Chapter-1.html" and therefore only the last-scraped "Chapter 1" will be used for all chapters called "Chapter 1". A situation where this commonly occurs is when the novel is split of into volumes and the link text does not include the volume and the chapter count is reset after every volume.

This issue only occurs starting from this commit: 1e8e89f

Before this commit each chapter has a unique, always incrementing 5 digit prefix (e.g. "00001-Chapter-01.html") and therefore does not have this bug.

@Flameish
Copy link
Owner

Thank you very much for your extensive bug report! I've added the old file naming back in and pushed the commit. A new compiled build will follow later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants