Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableSharding #472

Closed
bootstraponline opened this issue Jan 24, 2019 · 1 comment
Closed

disableSharding #472

bootstraponline opened this issue Jan 24, 2019 · 1 comment

Comments

@bootstraponline
Copy link
Contributor

If disableSharding is true then we should skip trying to shard methods. Sharding is currently incompatible with parameterized tests on both Android and iOS.

The following iOS code will then be updated

before:

// Parameterized tests on iOS don't shard correctly.
        // Avoid changing Xctestrun file when test shards is 1.
        val generatedXctestrun = if (args.testShards == 1) {
            xcTestParsed.toByteArray()
        } else {
            Xctestrun.rewrite(xcTestParsed, methods)
        }

after:

// Parameterized tests on iOS don't shard correctly.
        // Avoid changing Xctestrun file when test shards is 1.
        val generatedXctestrun = if (args.disableSharding == 1) {
            xcTestParsed.toByteArray()
        } else {
            Xctestrun.rewrite(xcTestParsed, methods)
        }

This will also help on Android where the apk fails to be parsed by dex-test-parser.

@bootstraponline
Copy link
Contributor Author

/cc @ceaglest @paynerc once this feature lands, you'll want to set disableSharding: true when using parameterized tests. #433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant