New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing the --test & --xctestrun-file via CLI not working #564

Closed

v-ahadke opened this issue Jun 19, 2019 · 2 comments · Fixed by #566

Assignees

v-ahadke commented Jun 19, 2019

When I pass the --test & --xctestrun-file via CLI , it exits the command with test is not set message. So looks like https://github.com/TestArmada/flank/blob/380de617040ab049de94491e4911d97b83e6630f/test_runner/src/main/kotlin/ftl/args/yml/IosGcloudYml.kt#L33 & https://github.com/TestArmada/flank/blob/380de617040ab049de94491e4911d97b83e6630f/test_runner/src/main/kotlin/ftl/args/yml/IosGcloudYml.kt#L34 causing the issue.

If I understand the code correctly, it expects the yml file must have entries for https://github.com/TestArmada/flank/blob/380de617040ab049de94491e4911d97b83e6630f/test_runner/src/main/kotlin/ftl/args/yml/IosGcloudYml.kt#L29 which will restrict user to pass them via CLI.

Can someone please check this? Thanks

The text was updated successfully, but these errors were encountered:

bootstraponline mentioned this issue

Fix --test & --xctestrun-file on iOS CLI #566

Merged

Contributor

bootstraponline commented Jun 19, 2019

Thanks for the feedback! I will fix this in #566 and make a new release today.

bootstraponline self-assigned this

bootstraponline closed this as completed in #566

Contributor

bootstraponline commented Jun 19, 2019

The issue has been resolved in https://github.com/TestArmada/flank/releases/tag/v6.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment