Use Dart Sass #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2020 17:58
Í moved all .scss files to the 'static' directory. Dart Sass must be used to convert these files to CSS. The scssLink partial does not use Hugo Pipes anymore, but does only generate a link to the .css file. Hugo Pipes uses LibSass, which currently does not support the new module system of SASS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hugo Pipes uses LibSass, but it is not fully compatible with the latest Sass specification and does lack features like the new module system. I used Hugo Pipes to convert SCSS to CSS and to add Subresource Integrity (SRI).
Dart Sass is now used to process the .scss files. It runs in the build pipeline after Hugo. Hugo moves all files and folders in the static directory to the output directory. Dart Sass processes the content of the [outputDir]/style directory and removes all .scss files afterwards.
Currently, all .scss files are processed, but this does only take up a few more bytes on the server — the browser will only download the .css files it needs.
I removed SRI. Honestly, I only used it because it was so easy to add. Because I'm currently not using a CDN and SRI can sometimes lead to problems (it was with caching, if I remember correctly), I will not add it again in the near future.