Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testExecutableArgSingleCaseRegex is ignored #15

Closed
NovaNekmit opened this issue Dec 1, 2021 · 8 comments
Closed

testExecutableArgSingleCaseRegex is ignored #15

NovaNekmit opened this issue Dec 1, 2021 · 8 comments

Comments

@NovaNekmit
Copy link
Contributor

It was added to config and readme in 3e83088, but is never used.

Should be used here, but isn't: https://github.com/Florin-Popescu/vscode-unity-test-adapter/blob/master/src/adapter.ts#L427

Seems like a simple change, but I don't quite understand how it would get the test case name, as many of the functions are called with suite info only.

@Florin-Popescu
Copy link
Owner

Thanks for finding this. Looks like I completely forgot to follow through on that change. Planning to get this working around the holiday period.

@canton7
Copy link

canton7 commented Mar 2, 2023

Bump, just in case this has fallen off your radar. Thanks!

@ManuBoss55
Copy link

still no news?

@canton7
Copy link

canton7 commented Aug 3, 2023

Might be time for a fork, heh

@Florin-Popescu
Copy link
Owner

Hello!

I'm starting work on #12 and trying to understand what has changed in vscode APIs in the last 2 years since I've touched this extension. I will take a look at this issue afterwards since for now I'm not even sure whether the extension works any more.

I cannot say yet how long that will take since #12 may be pretty much a rewrite of the entire extension and I have very limited time. Any help would be appreciated!

@canton7
Copy link

canton7 commented Aug 15, 2023

It still works - I'm using it!

@Florin-Popescu
Copy link
Owner

Implemented this as part of the switch to native vscode API.

I thought that there's starting to be too many settings for this extension so I made the behavior hard coded instead of configurable. It will always pass -n testName to the test executable when a single test case (not a file) is run from the test interface. That will be replaced by -g testGroup -n testName if using the Fixtures test format.

@Florin-Popescu
Copy link
Owner

Hello, it's been almost a year with no news from you so I'm closing this. If you still need something, feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants