Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an OPS I would like to have a possibility to customize domain for the broker #295

Closed
ppawlowski opened this issue Feb 5, 2024 · 4 comments · Fixed by #359
Closed
Assignees
Labels
feature-request New feature or request that needs to be turned into Epic/Story details size:XS - 1 Sizing estimation point
Milestone

Comments

@ppawlowski
Copy link
Contributor

ppawlowski commented Feb 5, 2024

Description

At this moment domain for the broker is fixed - it will be always deployed on mqtt.$forge.domain domain.
As an OPS I would like to have the possibility to specify a domain for the broker service on my own.
@hardillb please share your thoughts.

This feature will also enable deployment of MQTT brokers into our staging environments, without the hard-coded ties of the existing domain configuration.

@ppawlowski ppawlowski added feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do labels Feb 5, 2024
@ppawlowski ppawlowski self-assigned this Feb 5, 2024
@hardillb
Copy link
Contributor

hardillb commented Feb 5, 2024

This will need some detailed thought.

The broker we deploy is not (currently) available for general purpose MQTT usage, it is very heavily locked down and tightly coupled to the authentication endpoints we have in the forge app.

While we could choose to host it on a different hostname/domain it is still going to need to be the version of mosquitto configured with the tight auth plugin to work, not a different broker hosted outside the control of FF.

Assuming this is just a change to the hostname/domain it will also need to be passed to the forge app via the flowforge.yml as this value needs to be passed to devices and instances as part of configuration.

@ppawlowski
Copy link
Contributor Author

Assuming this is just a change to the hostname/domain it will also need to be passed to the forge app via the flowforge.yml as this value needs to be passed to devices and instances as part of configuration.

That is the only change I was thinking about. No changes to the broker itself were planned.

@hardillb
Copy link
Contributor

hardillb commented Feb 5, 2024

OK, low priority unless it's actively breaking something (I assume this is from the pr deploy stuff Steve asked about)

@ppawlowski ppawlowski moved this to Todo in 🛠 Development Feb 5, 2024
@ppawlowski ppawlowski changed the title As a OPS I would like to have a possibility to customize domain for the broker As an OPS I would like to have a possibility to customize domain for the broker Feb 5, 2024
@ppawlowski ppawlowski added this to the 2.2 milestone Mar 5, 2024
@ppawlowski ppawlowski modified the milestones: 2.2, 2.3 Apr 2, 2024
@ppawlowski ppawlowski moved this from Todo to Up Next in 🛠 Development Apr 2, 2024
@ZJvandeWeg
Copy link
Member

@MarianRaphael @joepavitt Can you update the description with how this factors in with the CD that's now blocked? The description makes it sound like a nice to have.

@ppawlowski ppawlowski added size:XS - 1 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Apr 2, 2024
@ppawlowski ppawlowski moved this from Up Next to In Progress in 🛠 Development Apr 2, 2024
@joepavitt joepavitt moved this from In Progress to Review in 🛠 Development Apr 4, 2024
@ppawlowski ppawlowski moved this from Review to Done in 🛠 Development Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request that needs to be turned into Epic/Story details size:XS - 1 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants