Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to seperate FlowFuse app Ingress Annoations from NR Instance Ingress Annotations #475

Closed
hardillb opened this issue Oct 4, 2024 · 0 comments · Fixed by #511
Closed

Need to seperate FlowFuse app Ingress Annoations from NR Instance Ingress Annotations #475

hardillb opened this issue Oct 4, 2024 · 0 comments · Fixed by #511
Assignees
@ppawlowski
Labels
needs-triage Needs looking at to decide what to do

Comments

@hardillb
Copy link
Contributor

hardillb commented Oct 4, 2024

Current Behavior

The same annotations (e.g. nginx.ingress.kubernetes.io/server-snippet is applied to both the Forge App and the NR instances.

Expected Behavior

Separate control for both (and probably the broker ingress rules as well)

Steps To Reproduce

set ingress.annotations in the values.yml passed to the helm chart

Environment

  • FlowFuse version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Helm version 2.15.0

Linked Customers

  • Customer name and/or link to HubSpot contact
@hardillb hardillb added the needs-triage Needs looking at to decide what to do label Oct 4, 2024
@ppawlowski ppawlowski mentioned this issue Oct 4, 2024
Closed
@ppawlowski ppawlowski self-assigned this Oct 4, 2024
@ppawlowski ppawlowski moved this to Todo in 🛠 Development Oct 6, 2024
@ppawlowski ppawlowski moved this from Up Next to In Progress in 🛠 Development Dec 2, 2024
@ppawlowski ppawlowski mentioned this issue Dec 2, 2024
Merged
10 tasks
@ppawlowski ppawlowski moved this from In Progress to Review in 🛠 Development Dec 3, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in 🛠 Development Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppawlowski ppawlowski

Labels
needs-triage Needs looking at to decide what to do
Projects
☁️ Product Planning
Status: Closed / Done
🛠 Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Separate project's and core app ingress annotations FlowFuse/helm
2 participants
@hardillb @ppawlowski