Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Theme Build #153

Open
joepavitt opened this issue Aug 3, 2023 · 1 comment
Open

Failing Theme Build #153

joepavitt opened this issue Aug 3, 2023 · 1 comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@joepavitt
Copy link
Contributor

Current Behavior

https://github.com/flowforge/flowforge-nr-launcher/actions/runs/5748418128/job/15581239068

Seems to be a relative path issue for where node-red gets checked out into.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

  • FlowForge version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:
@joepavitt joepavitt added needs-triage Needs looking at to decide what to do bug Something isn't working labels Aug 3, 2023
@Steve-Mcl
Copy link
Contributor

Same again today: https://github.com/FlowFuse/nr-launcher/actions/runs/6891562208/job/18746884869

Looks like it passes the existence check on Line 38, but then at lib/theme/scripts/build.js:119:17 attempts to read from __dirname + options.scr - these are in confict with one another,

Looking into it.

@Steve-Mcl Steve-Mcl mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
☁️ Product Planning
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Steve-Mcl @joepavitt