fix compiler warning and add option to control systemd service file installation #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix type-punnned pointer warning
awalwm2m-0.2.4/core/src/common/lwm2m_tlv.c:344:9: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
int32_t temp = htonl(*(uint32_t*)&f);
2. fix may be used uninitialized warning
daemon/src/server/lwm2m_server_xml_handlers.c: In function ‘xmlif_HandlerWriteRequest’:
daemon/src/server/lwm2m_server_xml_handlers.c:1781:5: error: ‘root’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
Lwm2mTreeNode_DeleteRecursive(root);
^
Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
install systemd service file only if WITH_SYSTEMD is enabled as not all system will use systemd by default especially embedded systems. Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
|
Can one of the admins verify this patch? |
|
retest AWS CI (erbium) |
|
retest AWS CI (libcoap) |
|
@abhimanyuv1 sorry, could you re-merge please? thanks |
|
hi matt, I had some comment in mail but cant find them here, if you want i can send 2 pull request for those patches? |
|
retest AWS CI (erbium) |
|
retest AWS CI (libcoap) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.