Rework the Contiki network address cache #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esses Signed-off-by: Michal Tusnio <m.tusnio@gmail.com>
|
@mtusnio you'll need the other line from the patch otherwise you'll end up with useCount=2 on the first call. |
|
@cheekyhalf I don't have access to the patch at the moment, can you attach the diff with that line so that I can update the PR? |
|
retest AWS CI (libcoap) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cheekyhalf This uses one of the fixes from your patch, lines 254-257. Otherwise it fails to bootstrap
The whole cache has been reworked to first parse the URI, then compare using Contiki implementation of network addresses. It compares them based on port & IP, and any URI comparison is gone at this point. This should solve the issue with cache overflowing when, for instance, doing observes which pass a slightly different URI to the application.