-
-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] support endpoint config for s3 #2718
Comments
which endpoint config? currently we support S3 for storage - https://docs.flowiseai.com/configuration/environment-variables#for-storage |
https://github.com/aws/aws-sdk-js-v3/blob/44475422c0c87ac92cba77d6a27d07e5e15c6281/supplemental-docs/CLIENTS.md?plain=1#L154-L174 |
If we can set this |
diff --git a/packages/components/src/storageUtils.ts b/packages/components/src/storageUtils.ts
index 483eb9ae..44f2244b 100644
--- a/packages/components/src/storageUtils.ts
+++ b/packages/components/src/storageUtils.ts
@@ -318,6 +318,7 @@ export const getS3Config = () => {
const secretAccessKey = process.env.S3_STORAGE_SECRET_ACCESS_KEY
const region = process.env.S3_STORAGE_REGION
const Bucket = process.env.S3_STORAGE_BUCKET_NAME
+ const endpoint = process.env.S3_ENDPOINT
if (!region || !Bucket) {
throw new Error('S3 storage configuration is missing')
}
@@ -332,7 +333,8 @@ export const getS3Config = () => {
const s3Client = new S3Client({
credentials,
- region
+ region,
+ endpoint: endpoint
})
return { s3Client, Bucket }
} I write a demo patch(I'm not familar with ts), could you help to commit it? |
added PR - #2891 |
PR merged, will be pushed to next release! |
Describe the feature you'd like
Support endpoint config for s3, so we can use s3 compatiable service like minio, aliyun oss,etc.
The text was updated successfully, but these errors were encountered: