#40 ESLintルールの整備 #142

FltSv · 2024-09-24T12:45:09Z

No description provided.

github-actions · 2024-09-24T12:46:49Z

Hosting/src/components/pages/Login.tsx

          className="w-fit bg-white text-black"
-          onClick={() => void loginWith('google')}>
+          onClick={() => void loginWith('google')}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:49Z

Hosting/src/components/pages/Login.tsx

          className="hidden w-fit bg-white text-black"
-          onClick={() => void loginWith('facebook')}>
+          onClick={() => void loginWith('facebook')}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:49Z

Hosting/src/components/pages/Map.tsx

@@ -26,9 +26,9 @@ const TODAY = new Date();
 export const Map = () => (
  <div className="h-svh w-svw bg-white">
    <GeolocationWrapper
+      renderErrorView={error => <MapView error={error} />}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:49Z

Hosting/src/components/pages/Mypage.tsx

                onClick={() => {
                  const links = creator.links.filter(x => x !== link);
                  setCreator({ ...creator, links });
-                }}>
+                }}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:49Z

Hosting/src/components/pages/Mypage.tsx

+              <MuiJoyButton
+                color="neutral"
+                disabled={addLinkError}
+                onClick={onAddLink}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:50Z

Hosting/src/components/pages/Mypage.tsx

            onClick={() => {
              onDelete(data);
-            }}>
+            }}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:50Z

Hosting/src/components/pages/Mypage.tsx

          onClick={e => {
            clearErrors('name');
            void handleSubmit(onValid)(e);
-          }}>
+          }}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:50Z

Hosting/src/components/pages/Verify.tsx

+    onClick={() =>
+      void (async () => {
+        // 確認メールを再送信
+        await sendVerifyEmail();

-          // ReSentページに遷移
-          props.setter();
-        })()
-      }>
-      確認メールを再送信する
-    </a>
-  );
-};
+        // ReSentページに遷移
+        props.setter();
+      })()
+    }>


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:50Z

Hosting/src/components/ui/DraggableList.tsx

      collisionDetection={closestCenter}
+      onDragEnd={onDragEnd}


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:50Z

Hosting/src/components/ui/Header.tsx

                MyPage
              </Link>
            )}
            {visibleLogout && (
-              <Link onClick={onSignOut} to="/" className={styles}>
+              <Link className={styles} onClick={onSignOut} to="/">


⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

github-actions · 2024-09-24T12:46:52Z

Hosting/src/components/pages/Mypage.tsx

⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

GalleryFound/Hosting/src/components/pages/Mypage.tsx

Lines 234 to 251 in 97c7e03

renderItem={(product, props) => (

<ProductCell

data={product}

key={product.id}

onDelete={() => {

const newProducts = creator.products.filter(

x => x.id !== product.id,

);

setCreator({ ...creator, products: newProducts });

}}

onEdit={() => {

setEditProduct(product);

setVisibleProductPopup(true);

}}

sortableProps={props}

/>

)}

github-actions · 2024-09-24T12:46:53Z

Hosting/src/components/pages/Mypage.tsx

⚠️ [eslint] <react/jsx-no-bind> _{reported by reviewdog 🐶}
JSX props should not use arrow functions

GalleryFound/Hosting/src/components/pages/Mypage.tsx

Lines 642 to 666 in 97c7e03

render={({ field }) => (

<Autocomplete

freeSolo

onChange={(e, value) => {

field.onChange(value);

}}

options={galleries?.map(x => x.name) ?? []}

renderInput={params => (

<Input

slotProps={{

root: { ref: params.InputProps.ref },

input: {

...params.inputProps,

onChange: e => {

field.onChange(e);

params.inputProps.onChange?.(e);

},

},

}}

sx={{ borderColor: 'black' }}

/>

)}

value={field.value || null}

/>

)}

github-actions · 2024-09-24T12:46:54Z

Hosting/src/components/ui/DraggableList.tsx

⚠️ [eslint] <func-style> _{reported by reviewdog 🐶}
Expected a function expression.

GalleryFound/Hosting/src/components/ui/DraggableList.tsx

Lines 30 to 73 in 97c7e03

export function DraggableList<T extends { id: string }>(

props: DraggableListProps<T>,

) {

const { items, setItems, renderItem } = props;

const [activeId, setActiveId] = useState<UniqueIdentifier>();

const sensors = useSensors(useSensor(MouseSensor), useSensor(TouchSensor));

const onDragStart = ({ active }: DragStartEvent) => {

setActiveId(active.id);

};

const onDragEnd = ({ active, over }: DragEndEvent) => {

if (active.id !== over?.id) {

const oldIndex = items.findIndex(item => item.id === active.id);

const newIndex = items.findIndex(item => item.id === over?.id);

setItems(arrayMove(items, oldIndex, newIndex));

}

};

const overlayItem = items.find(item => item.id === activeId);

return (

<DndContext

collisionDetection={closestCenter}

onDragEnd={onDragEnd}

onDragStart={onDragStart}

sensors={sensors}>

<SortableContext items={items} strategy={rectSortingStrategy}>

<div className="flex flex-wrap gap-2">

{items.map(item => (

<SortableItem item={item} key={item.id} renderItem={renderItem} />

))}

</div>

</SortableContext>

{overlayItem && (

<DragOverlay>

<SortableItem item={overlayItem} renderItem={renderItem} />

</DragOverlay>

)}

</DndContext>

);

}

github-actions · 2024-09-24T12:46:54Z

Hosting/src/components/ui/DraggableList.tsx

⚠️ [eslint] <func-style> _{reported by reviewdog 🐶}
Expected a function expression.

GalleryFound/Hosting/src/components/ui/DraggableList.tsx

Lines 80 to 109 in 97c7e03

function SortableItem<T extends { id: string }>(props: SortableItemProps<T>) {

const { item, renderItem } = props;

const {

attributes,

listeners,

setNodeRef,

transform,

transition,

isDragging,

} = useSortable({ id: item.id });

return (

<div

className="rounded-md bg-white bg-opacity-50 p-1 shadow-md"

ref={setNodeRef}

style={{

transform: CSS.Transform.toString(transform),

transition,

zIndex: isDragging ? 5 : 0,

opacity: isDragging ? 0.5 : 1,

}}>

{renderItem(item, {

...attributes,

...listeners,

...{ style: { cursor: 'grab' } },

})}

</div>

);

}

github-actions · 2024-09-24T13:07:47Z

Visit the preview URL for this PR (updated for commit 8771a47):

https://gallery-found--pr142-40-eslint-rule-cd66d2pk.web.app

_{(expires Tue, 01 Oct 2024 13:07:42 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: aacf5e596d89fd00b92da8ae1fefdbb554aab306}

FltSv added 13 commits September 22, 2024 10:16

#40 ESLint設定をルールはそのままで最新の書き方に修正

2792db6

#40 booleanへの型強制を禁止

99a0724

#40 演算子による暗黙的な型変換を禁止

8bd997e

#40 switch文周りのルール追加

3beb080

#40 mutable変数に対する警告ルールを追加

bc20c98

#40 ESLint Config Inspectorの読込不具合修正

74a0955

#40 メソッド記法の禁止

e323759

#40 配列のソートに引数を強制

c93e5af

#40 JSX内の関数記述禁止、関数記述方法を関数式に統一

fca4c43

#40 JSX周りのルール追加、軽微で済む修正の対応

d6a7efd

#40 react/jsx-sort-propsルールをerrorに変更、自動修正適用

27a307c

#40 webpackエラーの修正

4cff78a

#40 npm脆弱性対応

97c7e03

FltSv self-assigned this Sep 24, 2024

FltSv linked an issue Sep 24, 2024 that may be closed by this pull request

EsLintルール追加 #40

Closed

github-actions bot reviewed Sep 24, 2024

View reviewed changes

#40 PR Actionで警告は失敗扱いにしないよう修正

8771a47

FltSv force-pushed the 40-eslint-rule branch from dde63c7 to 8771a47 Compare September 24, 2024 13:05

FltSv temporarily deployed to production September 24, 2024 13:06 — with GitHub Actions Inactive

FltSv merged commit 02377db into develop Sep 25, 2024
6 checks passed

FltSv deleted the 40-eslint-rule branch September 25, 2024 01:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#40 ESLintルールの整備 #142

#40 ESLintルールの整備 #142

FltSv commented Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot commented Sep 24, 2024

	renderItem={(product, props) => (
	<ProductCell
	data={product}
	key={product.id}
	onDelete={() => {
	const newProducts = creator.products.filter(
	x => x.id !== product.id,
	);

	setCreator({ ...creator, products: newProducts });
	}}
	onEdit={() => {
	setEditProduct(product);
	setVisibleProductPopup(true);
	}}
	sortableProps={props}
	/>
	)}

	render={({ field }) => (
	<Autocomplete
	freeSolo
	onChange={(e, value) => {
	field.onChange(value);
	}}
	options={galleries?.map(x => x.name) ?? []}
	renderInput={params => (
	<Input
	slotProps={{
	root: { ref: params.InputProps.ref },
	input: {
	...params.inputProps,
	onChange: e => {
	field.onChange(e);
	params.inputProps.onChange?.(e);
	},
	},
	}}
	sx={{ borderColor: 'black' }}
	/>
	)}
	value={field.value \|\| null}
	/>
	)}

	export function DraggableList<T extends { id: string }>(
	props: DraggableListProps<T>,
	) {
	const { items, setItems, renderItem } = props;

	const [activeId, setActiveId] = useState<UniqueIdentifier>();
	const sensors = useSensors(useSensor(MouseSensor), useSensor(TouchSensor));

	const onDragStart = ({ active }: DragStartEvent) => {
	setActiveId(active.id);
	};

	const onDragEnd = ({ active, over }: DragEndEvent) => {
	if (active.id !== over?.id) {
	const oldIndex = items.findIndex(item => item.id === active.id);
	const newIndex = items.findIndex(item => item.id === over?.id);

	setItems(arrayMove(items, oldIndex, newIndex));
	}
	};

	const overlayItem = items.find(item => item.id === activeId);

	return (
	<DndContext
	collisionDetection={closestCenter}
	onDragEnd={onDragEnd}
	onDragStart={onDragStart}
	sensors={sensors}>
	<SortableContext items={items} strategy={rectSortingStrategy}>
	<div className="flex flex-wrap gap-2">
	{items.map(item => (
	<SortableItem item={item} key={item.id} renderItem={renderItem} />
	))}
	</div>
	</SortableContext>
	{overlayItem && (
	<DragOverlay>
	<SortableItem item={overlayItem} renderItem={renderItem} />
	</DragOverlay>
	)}
	</DndContext>
	);
	}

	function SortableItem<T extends { id: string }>(props: SortableItemProps<T>) {
	const { item, renderItem } = props;

	const {
	attributes,
	listeners,
	setNodeRef,
	transform,
	transition,
	isDragging,
	} = useSortable({ id: item.id });

	return (
	<div
	className="rounded-md bg-white bg-opacity-50 p-1 shadow-md"
	ref={setNodeRef}
	style={{
	transform: CSS.Transform.toString(transform),
	transition,
	zIndex: isDragging ? 5 : 0,
	opacity: isDragging ? 0.5 : 1,
	}}>
	{renderItem(item, {
	...attributes,
	...listeners,
	...{ style: { cursor: 'grab' } },
	})}
	</div>
	);
	}

#40 ESLintルールの整備 #142

#40 ESLintルールの整備 #142

Conversation

FltSv commented Sep 24, 2024

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 24, 2024