Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading from metadata URL fails #288

Closed
tomusdrw opened this issue Jan 10, 2025 · 1 comment · Fixed by #301
Closed

Loading from metadata URL fails #288

tomusdrw opened this issue Jan 10, 2025 · 1 comment · Fixed by #301
Assignees
@wkwiatek
Labels
bug Something isn't working prio-high

Comments

@tomusdrw
Copy link
Contributor

tomusdrw commented Jan 10, 2025 •
edited
Loading

image

Seems that there is an issue with lang type being required, yet not being provided in case we load from metadata URL.
image

Steps to reproduce:

  1. Load from URL
  2. Copy&Paste the url to pvm-shell
  3. See the failure.

Most likely introduced in #224
@tomusdrw tomusdrw added the bug Something isn't working label Jan 10, 2025
@tomusdrw
Copy link
Contributor Author

tomusdrw commented Jan 10, 2025 •
edited
Loading

Would be solved by #194 but I guess as a quick fix we can either add lang type to metadata, just assume it's rust-like or add an extra selector when loading from url (can even be a prompt)

@tomusdrw tomusdrw mentioned this issue Jan 10, 2025
Merged
@wkwiatek wkwiatek self-assigned this Jan 20, 2025
@wkwiatek wkwiatek mentioned this issue Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkwiatek wkwiatek

Labels
bug Something isn't working prio-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect language the WASM is written in instead of asking user to prov… FluffyLabs/pvm-debugger
2 participants
@tomusdrw @wkwiatek