Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadmodel! example in the docs doesn't work #2191

Closed
jonathanBieler opened this issue Feb 16, 2023 · 2 comments · Fixed by #2194
Closed

loadmodel! example in the docs doesn't work #2191

jonathanBieler opened this issue Feb 16, 2023 · 2 comments · Fixed by #2194

Comments

@jonathanBieler
Copy link
Contributor

The docs (http://fluxml.ai/Flux.jl/stable/saving/) say you can load a model with :

model = loadmodel!(model, @load("mymodel.bson"))

but @load("mymodel.bson") returns nothing.

I think it should be something like loadmodel!(model, load("mymodel.bson")[:model]). Also it looks like this case is not tested (can't find it in test/utils.jl).

Flux v0.13.11 & BSON v0.3.6

@ToucheSir
Copy link
Member

Good catch, mind filing a PR?

@jonathanBieler
Copy link
Contributor Author

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants