Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: sort(d::Dict; args...) is deprecated, use sort!(OrderedDict(d); args...) instead. #2312

Closed
prbzrg opened this issue Aug 16, 2023 · 2 comments · Fixed by #2314
Closed

Comments

@prbzrg
Copy link
Contributor

prbzrg commented Aug 16, 2023

In precompilation, I got:

┌ Flux [587475ba-b771-5e3f-ad9e-33799f191a9c]
│  ┌ Warning: `sort(d::Dict; args...)` is deprecated, use `sort!(OrderedDict(d); args...)` instead.
│  │   caller = top-level scope at functor.jl:190
│  └ @ Core C:\Users\Hossein Pourbozorg\.julia\packages\Flux\pR3k3\src\functor.jl:190
@ToucheSir
Copy link
Member

Looks like Flux is inadvertently relying on some pirated methods from DataStructures or another library. The straightforward fix would be to replace

const GPU_BACKEND_ORDER = sort(
with a vector of pairs/tuples or another built-in ordered collection such as Base.ImmutableDict.

@AstitvaAggarwal
Copy link

AstitvaAggarwal commented Aug 26, 2023

im still facing this issue. using Julia v1.9.2 and Flux v0.14.2

Precompiling project...
  110 dependencies successfully precompiled in 1201 seconds. 209 already precompiled.
  5 dependencies had warnings during precompilation:
┌ Flux [587475ba-b771-5e3f-ad9e-33799f191a9c]
│  ┌ Warning: `sort(d::Dict; args...)` is deprecated, use `sort!(OrderedDict(d); 
args...)` instead.
│  │   caller = top-level scope at functor.jl:190
│  └ @ Core C:\Users\astit\.julia\packages\Flux\pR3k3\src\functor.jl:190
└

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants