Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight generalization of cat #184

Closed
wants to merge 1 commit into from
Closed

slight generalization of cat #184

wants to merge 1 commit into from

Conversation

pevnak
Copy link
Contributor

@pevnak pevnak commented Feb 25, 2018

I have generalized cat to allow multiple dimensions, since at the moment it cannot handle 4-dim arrays in convolutional functions.

At the moment, the backward path breaks with
cat(2,rand(4),rand(4))

Appropriate tests are added.

@MikeInnes MikeInnes force-pushed the master branch 4 times, most recently from 027a922 to 5cc6813 Compare April 15, 2018 14:07
@MikeInnes MikeInnes mentioned this pull request May 1, 2018
gustafsson added a commit to gustafsson/Flux.jl that referenced this pull request May 2, 2018
Co-authored-by: pevnak <pevnak@gmail.com>

# Conflicts:
#	test/tracker.jl
gustafsson added a commit to gustafsson/Flux.jl that referenced this pull request May 2, 2018
Co-authored-by: pevnak <pevnak@gmail.com>
@MikeInnes
Copy link
Member

Merged with #243 -- thanks 👍

@MikeInnes MikeInnes closed this May 7, 2018
MikeInnes pushed a commit that referenced this pull request Jun 20, 2018
Co-authored-by: pevnak <pevnak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants