Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental PR: Support separate benchmark tasks on GitHub Actions #21

Closed

Conversation

skyleaworlder
Copy link
Collaborator

PR Checklist

  • Tests are added
  • Documentation, if applicable

Description

I've split original benchmarks by GitHub Actions matrix, in order to avoid OOM issues.

image

I've validated the feasibility of merging BenchmarkResults and exporting the full report.

Since installing dependencies takes amount of time, I add a cache action before running benchmarks.

Item Before (s) After caching (s)
conv 354 264
upsample 354 222
flux 322 221
... ... ...

Approximately every matrix item can save 2mins, and Cache job takes 6mins. It can definitely save GitHub Actions quota.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@1358f3c). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage        ?   40.21%           
=======================================
  Files           ?        4           
  Lines           ?      189           
  Branches        ?        0           
=======================================
  Hits            ?       76           
  Misses          ?      113           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants