Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: change second-level spec #22

Merged

Conversation

skyleaworlder
Copy link
Collaborator

@skyleaworlder skyleaworlder commented Jul 20, 2023

PR Checklist

  • Tests are added
  • Documentation, if applicable

Description

Simply change second-level specification. Previously, using ":" to specify inner level, but now using "( )".

This is because I intend to use the same format as part of artifact's name directly, but upload-artifact action doesn't support ":" existence in file name.

In addition, using parentheses can better express the second level of meaning, which is subordinate to the first level.

(This issue updates the feature in #19)

@skyleaworlder
Copy link
Collaborator Author

Directly merge after passing CI testing.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@1358f3c). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   51.70%           
=======================================
  Files           ?        3           
  Lines           ?      147           
  Branches        ?        0           
=======================================
  Hits            ?       76           
  Misses          ?       71           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skyleaworlder skyleaworlder merged commit 289ec57 into FluxML:main Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants