-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design #1
Comments
How different is this design from the current |
It's designed to be essentially similar but with explicit state, rather than using IdDicts everywhere. I haven't really figured out how to make it convenient yet, though, so help is welcome. One advantage of this design is that it's flexible enough that e.g. |
this has been done I guess |
Have been discussing with @pkofod how to design optimisers that can be used across Flux, Optim.jl and perhaps others. It seems the basic outline of a design in FluxML/Flux.jl#637 is something that Optim can work with. We're currently looking at splitting this into:
Some design goals from my side:
Colors
are updated (e.g. clamp the values).apply
should supportstate=nothing
optimisers in a generic way.update!
, but at this level we don't need to do any in-place/out-of-place detection.The current default for
update(x, dx)
is to calculatex .- dx
; this is convenient for ML but could be changed if it's inconvenient for other things (we'll just do the negation as part of the rule).The text was updated successfully, but these errors were encountered: