Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitalized desktop filename #220

Open
bilelmoussaoui opened this issue Jan 13, 2016 · 7 comments
Open

capitalized desktop filename #220

bilelmoussaoui opened this issue Jan 13, 2016 · 7 comments

Comments

@bilelmoussaoui
Copy link
Contributor

The script does not detect desktop files if it has some letter uppercase/lowercase
For example Playonlinux in fedora's desktop filename is PlayOnLinux

@Foggalong
Copy link
Owner

If you're experiencing a new bug, I'm not sure that's the problem. On my system it works fine with Prison Architect.desktop, Cities in Motion 2.desktop, Dota 2.desktop, Dwarfs!.desktop, FoxitReader.desktop, Hotline-Miami.desktop, Left 4 Dead 2.desktop, LittleInferno.desktop, Sid Meier's Civilization V.desktop, and Trine.desktop all of which have uppercase characters

@bilelmoussaoui
Copy link
Contributor Author

I think that you misunderstood me :P If you take a look at playonlinux entry in the database file https://github.com/Foggalong/hardcode-fixer/blob/master/tofix.csv#L254
In fedora the desktop file name is PlayOnLinux with the same hardcoded icon name. I don't think that we should add a new entry just for that.. Hope it's clear now!

@Foggalong
Copy link
Owner

Ah, it's a nice idea but since in theory any of the characters could be upper or lower case it would increase computation time a fair bit to iterate through them all.

@bilelmoussaoui
Copy link
Contributor Author

We can just lowercase both of files names during the execution of the script (just to check if the file exists)

@Foggalong
Copy link
Owner

In principal it's a sound idea, but I think it might work out as less optimised with the relatively small number of file names that fit that description. Happy to be proved wrong mind if that isn't the case

@bilelmoussaoui
Copy link
Contributor Author

I don't have any idea how to implement this at the moment :pi will see if i will get some ideas in the near future

@Foggalong
Copy link
Owner

No problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants