Entities to html

[patrickknaap]

If there are character entities in your html, they will now be
converted too.

[yuchi]

This is great! But looks like you modified the wrong file!
The file nl.fokkezb.html2as.js is a ‘compiled’ one. This one is the ‘source’.

Also you’re replacing the entities in the wrong phase, that is before parsing it. This means that

<b>hi</b>

is interpreted as

<b>hi</b>

[yuchi]

And (just being pedantic, I know) but probably it should be more solid to use this entities module (on GitHub and npm) instead of a homebrewed entity -> codepoint map.

[FokkeZB]

I agree that would be better. Could you modify the right file to use entities @patrickknaap? Just add the entities module to the package.json.

[patrickknaap]

Sorry for the long wait. I was very busy at my job. But I found some time.
It was the first time working on a module for me (and also with Grunt), so please inform me about my work.

[yuchi]

Way better! But I’m scared by the fact that we’re unescaping the entities after the creation of attributes. You have to know they are character position based

"Hallo <b>world</b>"

   -- becomes --

           ╭ strong [6:11]
         ┌─┴─┐
  "Hallo world"

but when we put escaping in the mix

"Hall&ograve; <b>world</b>"

      -- becomes --

                   ╭ strong [13:18]
                 ┌─┴─┐
   "Hall&ograve; world"
        ┬─────── ┊   ┊
   "Hallò world" ?????

[FokkeZB]

@yuchi it looks like it is correctly done before the creation of attributers right?

https://github.com/patrickknaap/ti-html2as/blob/entities-to-html/index.js#L135-L138

[yuchi]

Actually not. The attributes are created after the unescaping, but the ranges are created before.

[yuchi]

This line is where it should happen, probably…

parameters.text += entities.decodeHTML(node.data);

so when later you use parameters.length you get the right one.

[FokkeZB]

Yes, you're totally right @yuchi

Could you fix that @patrickknaap? Thx

[yuchi]

Don’t take my words for granted, @patrickknaap. Could you try if, after the eventual fix, the html Hall&ograve; <b>world</b> outputs «Hallò world» correctly?

[patrickknaap]

You're right @yuchi . The output wasn't the expected output. The ò was parsed correctly, but the ' world' didn't output in bold. I'll push a new version.