Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

More informative response to audio download failure? #94

Open
HelenFoster opened this issue Oct 17, 2018 · 2 comments
Open

More informative response to audio download failure? #94

HelenFoster opened this issue Oct 17, 2018 · 2 comments

Comments

@HelenFoster
Copy link
Contributor

Looks like it was decided that failure to download audio shouldn't be a fatal error for creating the card. But at the moment it just fails silently. Perhaps a compromise would be to write the reason for the error into the audio field?

@FooSoft
Copy link
Owner

FooSoft commented Oct 19, 2018

The problem is that setting an error value indicates that the entire operation failed. I think a better approach would be to provide a parameter that specifies whether or not failure to download audio is considered failure to create a card.

@HelenFoster
Copy link
Contributor Author

I agree, it would be useful to have a parameter that specifies whether or not failure to download audio is considered failure to create a card. Personally, I'd prefer it fail to create the card, because creating a bunch of cards and then noticing afterwards that they don't have audio is a pain.

The thing I suggested above, I actually did it in #97 - and maybe I shouldn't have lumped the two things together, but the other thing is kind of impossible to test without also somehow changing the error reporting code.

Maybe 3 options? Fail to create the card, store the error in Anki, or fail silently as it does now. (And failing silently shouldn't be the default, because it makes people go "my cards don't have audio and I have no idea why".)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants