Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

March 2021 Release #1580

Closed
11 tasks done
toasted-nutbread opened this issue Apr 1, 2021 · 16 comments
Closed
11 tasks done

March 2021 Release #1580

toasted-nutbread opened this issue Apr 1, 2021 · 16 comments

Comments

@toasted-nutbread
Copy link
Collaborator

toasted-nutbread commented Apr 1, 2021

https://github.com/FooSoft/yomichan/releases/tag/21.3.31.1

@FooSoft

General

Testing

Stable

  • Update Chrome stable release.
  • Update Firefox stable release.
  • Upload stable builds to the GitHub release.

Issues to address before stable

@toasted-nutbread toasted-nutbread pinned this issue Apr 1, 2021
@FooSoft
Copy link
Owner

FooSoft commented Apr 2, 2021

Testing release up!

@Thermospore
Copy link
Contributor

I'd like to try using the new option hotkey feature to toggle a dictionary. Is there an easy way to find the path for a given option? Might be nice to add a little explanation text in the menu there

Also does that only work for these kinds of options?
image
or can it cycle through dropdown lists as well

@toasted-nutbread
Copy link
Collaborator Author

Check options-schema.json or export your settings file and look at the paths. Paths start relative to profile[current].options, and the box will outline in red if the path is invalid. It only works on booleans.

@grospoulpe
Copy link

grospoulpe commented Apr 3, 2021

Just installed, with all the dictionaries I use (or not ;p), keeping the stable version (I suppose we have to, and eventually will become that new version)
So far, so good - and be able to play a different audio source with a keyboard shortcut is great / timesaving :)
And the possibility to collapse dictionaries (especially with 研究社 新和英大辞典 第5版 , which has a lot of example displayed) is a useful feature, too :)

@Aridow
Copy link

Aridow commented Apr 3, 2021

I noticed it's no longer possible to drag and drop kanjis from kanjidics dictionaries on Firefox. Is it expected?
Here's what I mean on Chrome :
image

@toasted-nutbread
Copy link
Collaborator Author

I noticed it's no longer possible to drag and drop kanjis from kanjidics dictionaries on Firefox. Is it expected?

No, apparently this has been an issue for a while though. #1586 fixes it. If you want to patch your styles, you can add this custom CSS:

.kanji-glyph {
    position: static;
    z-index: auto;
}
.kanji-tag-list {
  position: relative;
}
.entry[data-type=kanji] .entry-body-section[data-section-type=frequencies] {
  position: relative;
}

@qharscoet
Copy link

Hello,

I started diving into anki export customisation yesterday and saw that there are a lot of changes in this area in this release.
Would it be possible to expose back the JMDict sequence ID in the data ? Before it could be accessed in definitions.definitions[n].sequence but on testing it seems to be absent from the new anki logged format, or at -1. (see screenshort below)

(The Kanji Study app on Android allows dynamic open in app via a special URL that takes this as a parameter, really neat feature to be able to embed this in the cards when syncing with mobile)

image

@toasted-nutbread
Copy link
Collaborator Author

I started diving into anki export customisation yesterday and saw that there are a lot of changes in this area in this release.
Would it be possible to expose back the JMDict sequence ID in the data ? Before it could be accessed in definitions.definitions[n].sequence but on testing it seems to be absent from the new anki logged format, or at -1.

Yes, I have added it back in: #1591. This will be included in a patch before the stable release is made.

@Thermospore
Copy link
Contributor

Probably not new, I've seen similar cases before

If you search 殉じた, secondary search doesn't pull up the other 殉ずる definitions

image

image

similar example with 保身に走る

image

image

probably due to those dictionaries not having matching pos info

@toasted-nutbread
Copy link
Collaborator Author

Yes, it's due to the J2J dictionaries not having part of speech information, which is used to filter when inflections are involved. There is potentially a case to be made to not merge definitions into the same entry if they don't have matching POS info.

@Thermospore
Copy link
Contributor

There is potentially a case to be made to not merge definitions into the same entry if they don't have matching POS info.

Maybe they could still be pulled up, but with a tag to warn you the pos info is missing/doesn't match? Seems like the secondary search is a great way to get around dictionaries missing pos info. More pros than cons I think

@toasted-nutbread
Copy link
Collaborator Author

@FooSoft Should be ready for stable, updated the top comment.

@FooSoft
Copy link
Owner

FooSoft commented Apr 12, 2021

Shipped!

@qharscoet
Copy link

@toasted-nutbread I guess the patch from #1591 didn't make it in the final release :'(

@toasted-nutbread
Copy link
Collaborator Author

toasted-nutbread commented Apr 15, 2021

Oh shoot, you're right, I forgot to include that in the list. I'll set up a patch release for @FooSoft.

https://github.com/FooSoft/yomichan/releases/tag/21.3.31.2

General

Testing

Stable

  • Update Chrome stable release.
  • Update Firefox stable release.
  • Upload stable builds to the GitHub release.

@FooSoft
Copy link
Owner

FooSoft commented Apr 17, 2021

Shipped to testing and stable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants